Fix spurious seeding by switching to keyword args. #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldeistler
approved these changes
Sep 30, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
=======================================
Coverage 75.58% 75.58%
=======================================
Files 80 80
Lines 6254 6254
=======================================
Hits 4727 4727
Misses 1527 1527
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Sure, that also works -- added it in. |
jan-matthis
force-pushed
the
fix_simulate_in_batches_args
branch
from
30833be
to
6d0629e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simulate_for_sbicallssimulate_in_batcheswith wrong positional arguments: 5afd40b added seed as an extra argument forsimulate_in_batcheswhich was not reflected at the call site. Thus,show_progress_bar(defaulting to True) is erroneously used as the value for seed. This PR proposes to fix the resulting spurious seeding by switching from positional to keyword arguments.